Separate captures in DSLTree #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Mar 12, 2022
Rename Alternation to OrderedChoice, scrap groupTransform and capturing from group in favor of a capture node.
|
@swift-ci please test |
rxwei
pushed a commit
to rxwei/swift-experimental-string-processing
that referenced
this pull request
Mar 21, 2022
Rename Alternation to OrderedChoice, scrap groupTransform and capturing from group in favor of a capture node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternationtoorderedChoicecapturenode and changed group tononCapturingGroupgroupTransforminto just atransformfunction, which currently is only nested inside a captureOpen to suggestions. Another option with transforms, if they are only ever accessible directly inside a capture, is a
captureTransformnode. I weakly prefer consistency withmatcher.